Intern source images before any operation on them.

Functions must operate on store items and produce store items. Thus,
the set of store items is closed under the function. This closure
frees the function to not care about the origin of the store item.
Thus, the store item becomes a mere value to be passed around, rather
than a place with special meaning.

* ennum.el (ennum-publish-image): Only accept interned images.
(ennum-publish-link, ennum-publish): Intern images before passing them
to ennum-publish-image.

1 files changed, 15 insertions, 15 deletions

diff --git a/ennum.el b/ennum.el
index 106aa9a..0dd31a9 100644
--- a/ennum.el
+++ b/ennum.el
@@ -685,18 +685,17 @@ result as a string."
    "/"))
 
 (defun ennum-publish-image (image width)
-  (let ((interned-image (ennum-intern image)))
-    (ennum-exp
-     (message "Resizing %s to width %s" image width)
-     (ennum-mkdir-p (ennum-setting :images-directory))
-     (ennum-image-optimize-image
-      (ennum-image-resize-image
-       interned-image
-       (ennum--file-join
-        (ennum-setting :images-directory)
-        (ennum-image-output-filename
-         (file-name-nondirectory interned-image) width))
-       width)))))
+  (ennum-exp
+   (message "Resizing %s to width %s" image width)
+   (ennum-mkdir-p (ennum-setting :images-directory))
+   (ennum-image-optimize-image
+    (ennum-image-resize-image
+     image
+     (ennum--file-join
+      (ennum-setting :images-directory)
+      (ennum-image-output-filename
+       (file-name-nondirectory image) width))
+     width))))
 
 (defun ennum-publish-copy (file)
   (let ((interned-file (ennum-intern file)))
@@ -739,8 +738,8 @@ recognized as a directory, it should end in a slash. See
     ('image
      (seq-map (lambda (width)
                 (ennum-publish-image
-                 (ennum--file-join (ennum-setting :images-directory)
-                                   (ennum-link-path link))
+                 (ennum-intern (ennum--file-join (ennum-setting :images-directory)
+                                                 (ennum-link-path link)))
                  width))
               (list (ennum-setting :image-width)
                     (ennum-setting :image-link-width))))
@@ -828,7 +827,8 @@ as keys. Keys are compared using `equal'."
               ;; Publish thumbnails
               (seq-map (lambda (image)
                          (ennum-publish-image
-                          (ennum--file-join (ennum-setting :images-directory) image)
+                          (ennum-intern (ennum--file-join (ennum-setting :images-directory)
+                                                          image))
                           (ennum-setting :image-thumbnail-width)))
                        (ennum--filter-map 'ennum-post-thumbnail posts))
               ;; Publish other files