From 689eb3352fd4630b350f7482597775e8c8a65d1b Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Sun, 6 Aug 2017 22:54:07 +0530 Subject: Do not assign to innerHTML. * viewtube.js (createElement): Do not assign to innerHTML. Mozilla considers this unsafe. --- viewtube.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/viewtube.js b/viewtube.js index dfad54f..8ed1076 100644 --- a/viewtube.js +++ b/viewtube.js @@ -49,10 +49,8 @@ function createElement (type, attributes, parent) { var element = document.createElement(type); - for (var key in attributes) { - if (key == 'innerHTML') element.innerHTML = attributes[key]; - else element.setAttribute(key, attributes[key]); - } + for (var key in attributes) + element.setAttribute(key, attributes[key]); if (parent) parent.appendChild(element); return element; } -- cgit v1.2.3