From 24f722d39fc9b669554967ff6e74c99138d24261 Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Thu, 27 Nov 2025 00:52:18 +0000 Subject: workflow: Add defaults to inputs even with Workflow class workflows. Earlier, we were adding defaults only with CommandLineTool class workflows, and ignoring defaults in Workflow class workflows. --- .../tools/command-line-tool-step-with-default-input.scm | 8 ++++++++ ...nd-line-tool-step-with-optional-and-required-inputs.scm | 8 ++++++++ e2e-tests/tools/command-line-tool-with-default-input.scm | 4 ++++ e2e-tests/tools/workflow-step-with-default-input.scm | 12 ++++++++++++ .../workflow-step-with-optional-and-required-inputs.scm | 14 ++++++++++++++ e2e-tests/tools/workflow-with-default-input.scm | 8 ++++++++ 6 files changed, 54 insertions(+) create mode 100644 e2e-tests/tools/command-line-tool-step-with-default-input.scm create mode 100644 e2e-tests/tools/command-line-tool-step-with-optional-and-required-inputs.scm create mode 100644 e2e-tests/tools/command-line-tool-with-default-input.scm create mode 100644 e2e-tests/tools/workflow-step-with-default-input.scm create mode 100644 e2e-tests/tools/workflow-step-with-optional-and-required-inputs.scm create mode 100644 e2e-tests/tools/workflow-with-default-input.scm (limited to 'e2e-tests/tools') diff --git a/e2e-tests/tools/command-line-tool-step-with-default-input.scm b/e2e-tests/tools/command-line-tool-step-with-default-input.scm new file mode 100644 index 0000000..cb9ab44 --- /dev/null +++ b/e2e-tests/tools/command-line-tool-step-with-default-input.scm @@ -0,0 +1,8 @@ +(define echo + (command #:inputs (message #:type string + #:default "Hello world!") + #:run "echo" message + #:outputs (output_message #:type stdout))) + +(workflow () + (echo)) diff --git a/e2e-tests/tools/command-line-tool-step-with-optional-and-required-inputs.scm b/e2e-tests/tools/command-line-tool-step-with-optional-and-required-inputs.scm new file mode 100644 index 0000000..e6d0478 --- /dev/null +++ b/e2e-tests/tools/command-line-tool-step-with-optional-and-required-inputs.scm @@ -0,0 +1,8 @@ +(define echo + (command #:inputs (message1 #:type string) (message2 #:type string + #:default "Hello world!") + #:run "echo" message1 message2 + #:outputs (output_message #:type stdout))) + +(workflow ((message #:type string)) + (echo #:message1 message)) diff --git a/e2e-tests/tools/command-line-tool-with-default-input.scm b/e2e-tests/tools/command-line-tool-with-default-input.scm new file mode 100644 index 0000000..82801a4 --- /dev/null +++ b/e2e-tests/tools/command-line-tool-with-default-input.scm @@ -0,0 +1,4 @@ +(command #:inputs (message #:type string + #:default "Hello world!") + #:run "echo" message + #:outputs (output_message #:type stdout)) diff --git a/e2e-tests/tools/workflow-step-with-default-input.scm b/e2e-tests/tools/workflow-step-with-default-input.scm new file mode 100644 index 0000000..9a3f981 --- /dev/null +++ b/e2e-tests/tools/workflow-step-with-default-input.scm @@ -0,0 +1,12 @@ +(define echo + (command #:inputs (message #:type string) + #:run "echo" message + #:outputs (output_message #:type stdout))) + +(define echo-workflow + (workflow ((message #:type string + #:default "Hello world!")) + (echo #:message message))) + +(workflow () + (echo-workflow)) diff --git a/e2e-tests/tools/workflow-step-with-optional-and-required-inputs.scm b/e2e-tests/tools/workflow-step-with-optional-and-required-inputs.scm new file mode 100644 index 0000000..aa71940 --- /dev/null +++ b/e2e-tests/tools/workflow-step-with-optional-and-required-inputs.scm @@ -0,0 +1,14 @@ +(define echo + (command #:inputs (message1 #:type string) (message2 #:type string) + #:run "echo" message1 message2 + #:outputs (output_message #:type stdout))) + +(define echo-workflow + (workflow ((message1 #:type string) + (message2 #:type string + #:default "Hello world!")) + (echo #:message1 message1 + #:message2 message2))) + +(workflow ((message #:type string)) + (echo-workflow #:message1 message)) diff --git a/e2e-tests/tools/workflow-with-default-input.scm b/e2e-tests/tools/workflow-with-default-input.scm new file mode 100644 index 0000000..7f1a671 --- /dev/null +++ b/e2e-tests/tools/workflow-with-default-input.scm @@ -0,0 +1,8 @@ +(define echo + (command #:inputs (message #:type string) + #:run "echo" message + #:outputs (output_message #:type stdout))) + +(workflow ((message #:type string + #:default "Hello world!")) + (echo #:message message)) -- cgit 1.4.1